ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 31631: Testing of KDC connection doesn't work for UDP
Date Mon, 02 Mar 2015 20:15:11 GMT


> On March 2, 2015, 7:59 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java,
line 69
> > <https://reviews.apache.org/r/31631/diff/1/?file=882274#file882274line69>
> >
> >     This looks fine as is, but maybe this should be configurable in the future?

> >     
> >     I'm not an expert in UDP, but perhaps we should consider making this a configurable
setting, just to make things flexible in larger clusters.  
> >     
> >     Ten seconds is probably fine, it just might be nice to have the ability to customize
this value if we hit a network that needs a larger timeout.
> >     
> >     If there isn't really a need to customize this timeout property, then I'd recommend
making this final.

I don't really see a need to make the default value configurable and setUdpTimeout() allows
the default to be overriden.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31631/#review74804
-----------------------------------------------------------


On March 2, 2015, 7:06 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31631/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 7:06 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9870
>     https://issues.apache.org/jira/browse/AMBARI-9870
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The KDC connection test functionality that is used by the UI doesn't work when the KDC
server is configured to use UDP. 
> This is a significant issue on Ubuntu where the MIT KDC uses UDP as the default. 
> The current functionality only attempts to connect via TCP.
> 
> 
> Diffs
> -----
> 
>   ambari-project/pom.xml 0577bee 
>   ambari-server/pom.xml c57a2d0 
>   ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
8bfbc5f 
>   ambari-server/src/test/java/org/apache/ambari/server/api/rest/KdcServerConnectionVerificationTest.java
f8ec650 
> 
> Diff: https://reviews.apache.org/r/31631/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional Tests:
>  - both positive and negative tests for TCP and UDP
> 
> Unit Tests:
>  - added new unit tests for UDP validation
>  - all unit tests pass
>  
> Results :
> Tests run: 2751, Failures: 0, Errors: 0, Skipped: 15
> ...
> Total run:608
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message