ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 31624: SECONDARY_NAMENODE persist object in memory, causes HostVersion to stay in UPGRADING
Date Mon, 02 Mar 2015 15:38:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31624/
-----------------------------------------------------------

(Updated March 2, 2015, 3:38 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-9869
    https://issues.apache.org/jira/browse/AMBARI-9869


Repository: ambari


Description
-------

Finalize fails because one of the hosts (always the one that had the secondary namenode before)
still has a host_version with a state of UPGRADING and doesn't transition it to UPGRADED.

When the SECONDARY_NAMENODE is deleted via the Namenode HA wizard, the HostEntity may still
retain a reference to it, thereby causing the object to remain in memory.

For some reason the bi-directional relationships between the host entity and the state entities
are not cleaned up on the host side by JPA.

The patch uses a brute force approach to remove the state entites from the collections held
by the host entity.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
9635f30 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
66e91d3 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
fe5397b 

Diff: https://reviews.apache.org/r/31624/diff/


Testing (updated)
-------

Manual testing to verify that the HostEntity references to the state entities are cleaned
up.

All existing tests pass ...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:16 min
[INFO] Finished at: 2015-03-02T10:37:09-05:00
[INFO] Final Memory: 42M/568M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message