Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7496508241630871461=="
MIME-Version: 1.0
Subject: Re: Review Request 31487: Spark: spark-defaults.conf file does not
 contains added Custom properties from UI
From: "Gautam Borad" <gborad@gmail.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Giridharan Kesavan" <gkesavan@apache.org>,
 "Yusaku Sako" <yusaku@hortonworks.com>
Cc: "Gautam Borad" <gborad@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Fri, 27 Feb 2015 03:35:10 -0000
Message-ID: <20150227033510.1420.1545@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Gautam Borad" <noreply@reviews.apache.org>
References: <20150226184350.1420.57064@reviews.apache.org>
In-Reply-To: <20150226184350.1420.57064@reviews.apache.org>
Reply-To: "Gautam Borad" <gborad@gmail.com>

--===============7496508241630871461==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 26, 2015, 6:43 p.m., Alejandro Fernandez wrote:
> >
> 
> Alejandro Fernandez wrote:
>     Is this meant for both trunk and branch-2.0.0?

The fix is meant for Ambari-2.0 release. Am not aware if we have moved development to branch-2.0.0 now.


> On Feb. 26, 2015, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-env.xml, line 95
> > <https://reviews.apache.org/r/31487/diff/1/?file=878457#file878457line95>
> >
> >     Was this meant to be an "unset" instead?

Its meant to be set to Empty.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31487/#review74318
-----------------------------------------------------------


On Feb. 26, 2015, 2:57 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31487/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 2:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9811
>     https://issues.apache.org/jira/browse/AMBARI-9811
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1] spark-defaults.conf file does not contain properties that are added from the Custom spark-defaults accordion.
> Such values should be added to the SPARK_CONF/spark-defaults.conf dir
> 2] Add JAVA_HOME variable to spark-env.sh
> 3] Create an hdfs dir (/user/spark) for spark during setup.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-env.xml 15a71cd 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/metainfo.xml 95df6e5 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 41c0c9e 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py f73011b 
> 
> Diff: https://reviews.apache.org/r/31487/diff/
> 
> 
> Testing
> -------
> 
> Tested E2E on 3 node CentOS6 cluster.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


--===============7496508241630871461==--