Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EF8F10867 for ; Wed, 18 Feb 2015 20:22:17 +0000 (UTC) Received: (qmail 86012 invoked by uid 500); 18 Feb 2015 20:22:17 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 85981 invoked by uid 500); 18 Feb 2015 20:22:17 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 85966 invoked by uid 99); 18 Feb 2015 20:22:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 20:22:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5AF7B1D214A; Wed, 18 Feb 2015 20:22:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5352048906250787285==" MIME-Version: 1.0 Subject: Re: Review Request 31159: Views: Login redirection fails in Ambari when trying to access view From: "Tom Beerbower" To: "Yusaku Sako" , "Nate Cole" , "Jonathan Hurley" Cc: "Ambari" , "Tom Beerbower" Date: Wed, 18 Feb 2015 20:22:15 -0000 Message-ID: <20150218202215.21354.29446@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/31159/ X-Sender: "Tom Beerbower" References: <20150218195948.21353.54516@reviews.apache.org> In-Reply-To: <20150218195948.21353.54516@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============5352048906250787285== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 18, 2015, 7:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java, line 68 > > > > > > This could be configurable. The instance looks like it's loaded via an injector, so access to Configuration.class should be there. It could be but right now there is no requirement and Ambari Web needs to see it in this format. Thanks. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31159/#review72999 ----------------------------------------------------------- On Feb. 18, 2015, 8:17 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31159/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 8:17 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Yusaku Sako. > > > Bugs: AMBARI-9694 > https://issues.apache.org/jira/browse/AMBARI-9694 > > > Repository: ambari > > > Description > ------- > > Access a view (i.e. "http://c6501.ambari.apache.org:8080/views/TEZ/0.5.2.2.2.2.0-869/tez/#/tez-app/application_1423719241211_0050") from a browser where I have already logged in to Ambari, the link works fine. > When I access it from another browser, I get a 403 with no redirect to the login page. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java bedffbb > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java f3c6400 > > Diff: https://reviews.apache.org/r/31159/diff/ > > > Testing > ------- > > Manual tested. > New unit test added. > > All existing tests pass ... > > > Thanks, > > Tom Beerbower > > --===============5352048906250787285==--