Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 899F7107D8 for ; Sat, 14 Feb 2015 03:41:36 +0000 (UTC) Received: (qmail 86079 invoked by uid 500); 14 Feb 2015 03:41:36 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 86044 invoked by uid 500); 14 Feb 2015 03:41:36 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 86027 invoked by uid 99); 14 Feb 2015 03:41:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Feb 2015 03:41:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F01B21CF921; Sat, 14 Feb 2015 03:41:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1370400743267153915==" MIME-Version: 1.0 Subject: Re: Review Request 31035: Allow the KDC admin credentials stored in session to be validated via the REST API From: "Tom Beerbower" To: "Yusaku Sako" , "Robert Levas" , "Tom Beerbower" Cc: "John Speidel" , "Ambari" Date: Sat, 14 Feb 2015 03:41:34 -0000 Message-ID: <20150214034134.29075.55@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/31035/ X-Sender: "Tom Beerbower" References: <20150214010030.29075.67960@reviews.apache.org> In-Reply-To: <20150214010030.29075.67960@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============1370400743267153915== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31035/#review72481 ----------------------------------------------------------- Ship it! Looks good. - Tom Beerbower On Feb. 14, 2015, 1 a.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31035/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2015, 1 a.m.) > > > Review request for Ambari, Robert Levas, Tom Beerbower, and Yusaku Sako. > > > Bugs: AMBARI-9640 > https://issues.apache.org/jira/browse/AMBARI-9640 > > > Repository: ambari > > > Description > ------- > > Add the following properties to the Kerberos service resource which provide the results of the validation of the KDC admin credentials stored in session: "Services/attributes/kdc_validation_result" and "Services/attributes/kdc_validation_failure_details". > > See the associated Jira for more details including full api responses. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 2e68c7d > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 40921f5 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 210c6a4 > > Diff: https://reviews.apache.org/r/31035/diff/ > > > Testing > ------- > > Manual Functional Testing: > - Tested all possible results of the validation > - Tested when no kerberos service existed > > Unit Tests: > - Added new unit tests > - Running entire unit test suite now and will post results prior to merging > > > Thanks, > > John Speidel > > --===============1370400743267153915==--