Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08F9B10B1D for ; Thu, 12 Feb 2015 20:11:58 +0000 (UTC) Received: (qmail 59172 invoked by uid 500); 12 Feb 2015 20:11:58 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 59141 invoked by uid 500); 12 Feb 2015 20:11:58 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 59127 invoked by uid 99); 12 Feb 2015 20:11:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Feb 2015 20:11:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D0B641CC188; Thu, 12 Feb 2015 20:11:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1089671239441175591==" MIME-Version: 1.0 Subject: Re: Review Request 30943: RU: downgrade during Prepare Backups step causes issues From: "Nate Cole" To: "Tom Beerbower" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Thu, 12 Feb 2015 20:11:56 -0000 Message-ID: <20150212201156.29075.18903@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30943/ X-Sender: "Nate Cole" References: <20150212191309.11124.1810@reviews.apache.org> In-Reply-To: <20150212191309.11124.1810@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============1089671239441175591== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30943/ ----------------------------------------------------------- (Updated Feb. 12, 2015, 3:11 p.m.) Review request for Ambari, Jonathan Hurley and Tom Beerbower. Changes ------- Updated diff for comments Bugs: AMBARI-9603 https://issues.apache.org/jira/browse/AMBARI-9603 Repository: ambari Description ------- * Fixed case where manual tasks were being shown when the service does not get downgraded * Added directional element for groups and cluster execute-stage elements Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java f9336ef ambari-server/src/main/java/org/apache/ambari/server/stack/HostsType.java 556e5fa ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 0800c91 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f7a5276 ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java cade1b0 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java bf7a068 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 7c001d9 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java ec517d9 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java 81ec2ff ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 2e00b3e ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7df7b7b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 4c8cfc4 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 74b2495 ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java f4aa92d ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml PRE-CREATION ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 3dd7f2f Diff: https://reviews.apache.org/r/30943/diff/ Testing ------- Tests run: 2658, Failures: 0, Errors: 0, Skipped: 15 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 22:12.157s [INFO] Finished at: Thu Feb 12 13:55:24 EST 2015 [INFO] Final Memory: 31M/373M [INFO] ------------------------------------------------------------------------ Thanks, Nate Cole --===============1089671239441175591==--