Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5770D10FBD for ; Wed, 11 Feb 2015 14:20:43 +0000 (UTC) Received: (qmail 54867 invoked by uid 500); 11 Feb 2015 14:20:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 54833 invoked by uid 500); 11 Feb 2015 14:20:43 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 54814 invoked by uid 99); 11 Feb 2015 14:20:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Feb 2015 14:20:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4DBC11CF8BD; Wed, 11 Feb 2015 14:20:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2478597590264764276==" MIME-Version: 1.0 Subject: Re: Review Request 30878: Add service wizard: check (and fix if needed) handling KDC credentials error From: "Oleg Nechiporenko" To: "Oleg Nechiporenko" Cc: "Andriy Babiichuk" , "Ambari" Date: Wed, 11 Feb 2015 14:20:42 -0000 Message-ID: <20150211142042.29075.39607@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Oleg Nechiporenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30878/ X-Sender: "Oleg Nechiporenko" References: <20150211141949.11124.22069@reviews.apache.org> In-Reply-To: <20150211141949.11124.22069@reviews.apache.org> Reply-To: "Oleg Nechiporenko" X-ReviewRequest-Repository: ambari --===============2478597590264764276== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30878/#review71965 ----------------------------------------------------------- Ship it! Ship It! - Oleg Nechiporenko On Feb. 11, 2015, 2:19 p.m., Andriy Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30878/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 2:19 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-9565 > https://issues.apache.org/jira/browse/AMBARI-9565 > > > Repository: ambari > > > Description > ------- > > Add service wizard: check (and fix if needed) handling KDC credentials error > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/kerberos/step2_controller.js a641f4c8cb7391a51d0c212f2ebf25f6129bbadc > ambari-web/app/controllers/main/service/add_controller.js 7f86969b883b240ca541e1ca96ad971c4ac77502 > ambari-web/app/routes/add_service_routes.js 9122f9558c21782e4454b4456a1919e5c9fe3ac6 > ambari-web/app/utils/ajax/ajax.js fb01bb2d1cafa596d72fb4fb93087952de867eb2 > ambari-web/app/views/common/modal_popups/invalid_KDC_popup.js 1ecef788275f7965db3f19fb288f502283635893 > ambari-web/test/controllers/main/service/add_controller_test.js a688ad01f2cf09c45e65b6a7d2d7f33be46d8bc4 > > Diff: https://reviews.apache.org/r/30878/diff/ > > > Testing > ------- > > 5339 tests complete (10 seconds) > 62 tests pending > > > Thanks, > > Andriy Babiichuk > > --===============2478597590264764276==--