Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5943D10098 for ; Wed, 11 Feb 2015 00:44:16 +0000 (UTC) Received: (qmail 69866 invoked by uid 500); 11 Feb 2015 00:44:16 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 69833 invoked by uid 500); 11 Feb 2015 00:44:16 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 69817 invoked by uid 99); 11 Feb 2015 00:44:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Feb 2015 00:44:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 67DCC1CF879; Wed, 11 Feb 2015 00:44:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7374202215847462994==" MIME-Version: 1.0 Subject: Re: Review Request 30838: RU : Fail in DOWNGRADE finalize From: "Nate Cole" To: "Alejandro Fernandez" , "Yurii Shylov" Cc: "Nate Cole" , "Ambari" Date: Wed, 11 Feb 2015 00:44:15 -0000 Message-ID: <20150211004415.29075.98711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30838/ X-Sender: "Nate Cole" References: <20150210175053.29076.51127@reviews.apache.org> In-Reply-To: <20150210175053.29076.51127@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============7374202215847462994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30838/#review71889 ----------------------------------------------------------- Ping. This is a blocker. - Nate Cole On Feb. 10, 2015, 12:50 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30838/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 12:50 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Yurii Shylov. > > > Bugs: AMBARI-9540 > https://issues.apache.org/jira/browse/AMBARI-9540 > > > Repository: ambari > > > Description > ------- > > Update for FinalizeUpgradeAction to handle a downgrade and getting back to a state where the upgrade can be retried. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8e32b92 > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/30838/diff/ > > > Testing > ------- > > Manual UI testing up to final finalize, then click downgrade. All green with the option to click Upgrade again. > > Tests run: 2657, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 22:13.852s > [INFO] Finished at: Tue Feb 10 12:43:36 EST 2015 > [INFO] Final Memory: 34M/372M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============7374202215847462994==--