Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 62FAE10586 for ; Tue, 10 Feb 2015 16:28:30 +0000 (UTC) Received: (qmail 39282 invoked by uid 500); 10 Feb 2015 16:28:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 39247 invoked by uid 500); 10 Feb 2015 16:28:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 39229 invoked by uid 99); 10 Feb 2015 16:28:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 16:28:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8348B1CDE76; Tue, 10 Feb 2015 16:28:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4597671539750445040==" MIME-Version: 1.0 Subject: Re: Review Request 30568: [PREVIEW] Rolling Upgrade Bootstrap - Allow Ambari upgrade from 1.7.0 - 2.0.0 to populate new tables From: "Yurii Shylov" To: "Alejandro Fernandez" , "Nate Cole" , "Dmitro Lisnichenko" Cc: "Yurii Shylov" , "Ambari" Date: Tue, 10 Feb 2015 16:28:29 -0000 Message-ID: <20150210162829.29076.94734@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yurii Shylov" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30568/ X-Sender: "Yurii Shylov" References: <20150210162223.29075.91787@reviews.apache.org> In-Reply-To: <20150210162223.29075.91787@reviews.apache.org> Reply-To: "Yurii Shylov" X-ReviewRequest-Repository: ambari --===============4597671539750445040== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71797 ----------------------------------------------------------- ambari-common/src/main/python/resource_management/libraries/script/script.py I do not like this place as it's a duplication of code from params.py. The correct solution would be to create parent params.py on stack level, which would expose common for every component variables, but I do not want to take this responsibility on myself as I'm not that familiar with python code. I can make a separate jira if needed. Anyway, this implementation is safer and, I think, better than previous "import params". - Yurii Shylov On Фев. 10, 2015, 4:22 п.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Фев. 10, 2015, 4:22 п.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and host_version tables. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1 > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542 > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > Manual testing done, UT in progress > > > Thanks, > > Yurii Shylov > > --===============4597671539750445040==--