Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50BDA10F1C for ; Mon, 9 Feb 2015 21:31:46 +0000 (UTC) Received: (qmail 57947 invoked by uid 500); 9 Feb 2015 21:31:46 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 57912 invoked by uid 500); 9 Feb 2015 21:31:46 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 57889 invoked by uid 99); 9 Feb 2015 21:31:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 21:31:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 74A0A1CE0BA; Mon, 9 Feb 2015 21:31:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5435813060447280602==" MIME-Version: 1.0 Subject: Re: Review Request 30803: Some Alerts Have Stale Text And Do Not Recalculate Their State From: "Nate Cole" To: "Nate Cole" , "Tom Beerbower" Cc: "Ambari" , "Jonathan Hurley" Date: Mon, 09 Feb 2015 21:31:45 -0000 Message-ID: <20150209213145.29076.23889@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30803/ X-Sender: "Nate Cole" References: <20150209194537.29076.23825@reviews.apache.org> In-Reply-To: <20150209194537.29076.23825@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============5435813060447280602== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30803/#review71703 ----------------------------------------------------------- Ship it! Ship It! - Nate Cole On Feb. 9, 2015, 2:45 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30803/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 2:45 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-9538 > https://issues.apache.org/jira/browse/AMBARI-9538 > > > Repository: ambari > > > Description > ------- > > Hbase service alert for percent of RegionServers available doesn't disappear after a long time. Also, there is outdated alert text that doesn't match the current alert state. > > STR: > 1.Log in to ambari, go to services tab > 2.Choose Hbase > 3.In Service Actions drop-down choose stop > 4.Start service the same way > 5.Wait until in summary all components starts > > ER: Alerts will disappear after a while > AR: Alerts disappear after >5 min > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 02bbba9 > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 83ee231 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 51aa688 > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 789fa90 > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 023d0ad > > Diff: https://reviews.apache.org/r/30803/diff/ > > > Testing > ------- > > Manual verification of the initial problem as well as the fix. Added new tests to cover changed functionality. > > mvn clean test > > > Thanks, > > Jonathan Hurley > > --===============5435813060447280602==--