Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 997CB10141 for ; Mon, 9 Feb 2015 17:55:47 +0000 (UTC) Received: (qmail 54162 invoked by uid 500); 9 Feb 2015 17:55:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 54129 invoked by uid 500); 9 Feb 2015 17:55:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 54113 invoked by uid 99); 9 Feb 2015 17:55:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 17:55:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BDA4B1CE09E; Mon, 9 Feb 2015 17:55:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5758699696905042010==" MIME-Version: 1.0 Subject: Re: Review Request 30799: RU: upgrade task names should use display names rather than IDs From: "Tom Beerbower" To: "Tom Beerbower" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Mon, 09 Feb 2015 17:55:46 -0000 Message-ID: <20150209175546.29076.82226@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30799/ X-Sender: "Tom Beerbower" References: <20150209164600.29076.54549@reviews.apache.org> In-Reply-To: <20150209164600.29076.54549@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============5758699696905042010== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30799/#review71648 ----------------------------------------------------------- Ship it! Are new unit tests required? - Tom Beerbower On Feb. 9, 2015, 4:45 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30799/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 4:45 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-9533 > https://issues.apache.org/jira/browse/AMBARI-9533 > > > Repository: ambari > > > Description > ------- > > * Use AmbariMetaInfo in UpgradeHelper to get the display names for services/components and store them with the UpgradeContext for use in the StageWrapperBuilder classes. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 908e2d0 > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bc53b37 > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 129baa6 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 6213de1 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java fc51eb1 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Direction.java 376de14 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java ba4dca1 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java ac8b5dd > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java 3bf9098 > > Diff: https://reviews.apache.org/r/30799/diff/ > > > Testing > ------- > > Tests run: 2655, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 23:05.563s > [INFO] Finished at: Mon Feb 09 10:51:40 EST 2015 > [INFO] Final Memory: 34M/363M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============5758699696905042010==--