Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BEF5417B94 for ; Thu, 5 Feb 2015 14:03:39 +0000 (UTC) Received: (qmail 77313 invoked by uid 500); 5 Feb 2015 14:03:34 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 77278 invoked by uid 500); 5 Feb 2015 14:03:34 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 77262 invoked by uid 99); 5 Feb 2015 14:03:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 14:03:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C4FEE1C4A53; Thu, 5 Feb 2015 14:03:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5776492832227266005==" MIME-Version: 1.0 Subject: Re: Review Request 30641: RU: overall upgrade process is 100% before upgrade is done From: "Tom Beerbower" To: "Tom Beerbower" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Thu, 05 Feb 2015 14:03:29 -0000 Message-ID: <20150205140329.1285.21325@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30641/ X-Sender: "Tom Beerbower" References: <20150204223453.1286.82398@reviews.apache.org> In-Reply-To: <20150204223453.1286.82398@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============5776492832227266005== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30641/#review71208 ----------------------------------------------------------- Ship it! Looks good. - Tom Beerbower On Feb. 4, 2015, 10:34 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30641/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 10:34 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-9481 > https://issues.apache.org/jira/browse/AMBARI-9481 > > > Repository: ambari > > > Description > ------- > > * Fixed HostRoleCommand to return a better hashCode(), equals() as the old implementations did not consider that two tasks would have the same member values > * Added computation for groups > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 59fce90 > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java 24a4589 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 28e0d17 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java c89d005 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java ca1e583 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 00ba387 > > Diff: https://reviews.apache.org/r/30641/diff/ > > > Testing > ------- > > Tests run: 2642, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 26:54.495s > [INFO] Finished at: Wed Feb 04 17:21:08 EST 2015 > [INFO] Final Memory: 32M/368M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============5776492832227266005==--