Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5592A17AD5 for ; Tue, 3 Feb 2015 21:05:35 +0000 (UTC) Received: (qmail 60608 invoked by uid 500); 3 Feb 2015 21:05:36 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 60578 invoked by uid 500); 3 Feb 2015 21:05:36 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 60558 invoked by uid 99); 3 Feb 2015 21:05:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 21:05:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 559711CC37C; Tue, 3 Feb 2015 21:05:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1828219390738797340==" MIME-Version: 1.0 Subject: Re: Review Request 30468: Failing to register hosts on Centos5 From: "Jayush Luniya" To: "Mahadev Konar" , "Jayush Luniya" , "Dmytro Sen" Cc: "Florian Barca" , "Ambari" Date: Tue, 03 Feb 2015 21:05:39 -0000 Message-ID: <20150203210539.30544.96923@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jayush Luniya" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30468/ X-Sender: "Jayush Luniya" References: <20150203191125.30543.51180@reviews.apache.org> In-Reply-To: <20150203191125.30543.51180@reviews.apache.org> Reply-To: "Jayush Luniya" X-ReviewRequest-Repository: ambari --===============1828219390738797340== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30468/#review70829 ----------------------------------------------------------- ambari-server/src/test/python/TestSetupAgent.py I see following unit test failure with the patch. Failed tests: ERROR: test_runAgent (TestSetupAgent.TestSetupAgent) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/jluniya/clean/trunk/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched return func(*args, **keywargs) File "/Users/jluniya/clean/trunk/ambari/ambari-server/src/test/python/TestSetupAgent.py", line 66, in test_runAgent cmdStr = str(call_mock.call_args_list[0][0]) IndexError: list index out of range ---------------------------------------------------------------------- - Jayush Luniya On Feb. 3, 2015, 7:11 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30468/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 7:11 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc. > > > Diffs > ----- > > ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 > ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b > > Diff: https://reviews.apache.org/r/30468/diff/ > > > Testing > ------- > > Bootstrap in a local CentOS 5 cluster. > > > Thanks, > > Florian Barca > > --===============1828219390738797340==--