Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 85EF3175BD for ; Tue, 3 Feb 2015 19:11:24 +0000 (UTC) Received: (qmail 21000 invoked by uid 500); 3 Feb 2015 19:11:25 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 20968 invoked by uid 500); 3 Feb 2015 19:11:25 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 20947 invoked by uid 99); 3 Feb 2015 19:11:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 19:11:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8E0101CC37B; Tue, 3 Feb 2015 19:11:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9180370185573936297==" MIME-Version: 1.0 Subject: Re: Review Request 30468: Failing to register hosts on Centos5 From: "Florian Barca" To: "Mahadev Konar" , "Jayush Luniya" , "Dmytro Sen" Cc: "Florian Barca" , "Ambari" Date: Tue, 03 Feb 2015 19:11:28 -0000 Message-ID: <20150203191128.30543.765@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Florian Barca" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30468/ X-Sender: "Florian Barca" References: <20150130233821.1308.2247@reviews.apache.org> In-Reply-To: <20150130233821.1308.2247@reviews.apache.org> Reply-To: "Florian Barca" X-ReviewRequest-Repository: ambari --===============9180370185573936297== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 30, 2015, 11:38 p.m., Jayush Luniya wrote: > > ambari-server/src/main/python/setupAgent.py, line 245 > > > > > > It is odd that we are calling tryStopAgent() before parseArguments(). i.e. if incorrect/invalid args are passed we would end up stopping the agent and exiting with invalid arg exception. Yes, this is another consistency issue which will be addressed by a follow-up JIRA item. > On Jan. 30, 2015, 11:38 p.m., Jayush Luniya wrote: > > ambari-server/src/main/python/setupAgent.py, line 92 > > > > > > detecting verbose support should be refactored out of tryStopAgent. That way we can set verbosity independent of stopping the agent. Subject to follow-up. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30468/#review70442 ----------------------------------------------------------- On Feb. 3, 2015, 7:11 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30468/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 7:11 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc. > > > Diffs > ----- > > ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 > ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b > > Diff: https://reviews.apache.org/r/30468/diff/ > > > Testing > ------- > > Bootstrap in a local CentOS 5 cluster. > > > Thanks, > > Florian Barca > > --===============9180370185573936297==--