ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AMBARI-9501) Stack definition files include tab characters
Date Thu, 05 Feb 2015 19:17:34 GMT
Robert Nettleton created AMBARI-9501:
----------------------------------------

             Summary: Stack definition files include tab characters
                 Key: AMBARI-9501
                 URL: https://issues.apache.org/jira/browse/AMBARI-9501
             Project: Ambari
          Issue Type: Bug
          Components: ambari-server
    Affects Versions: 2.0.0
            Reporter: Robert Nettleton
             Fix For: 2.0.0


Some files in the stack defintions have recently been added with tab characters included,
instead of using the "Tabs as spaces" convention that is specified in the Ambari Coding guidelines:

https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari

The following files appear to use actual tab characters for spacing:

Under ambari-server:

src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml

src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml

 src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml

src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml

src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml


Having tab characters in these config files can cause problems for patches that modify these
files, since the IDEs we typically use do not use tab characters.  This can cause the formatting
of the actual diff between the branch and the local changes to not look as expected.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message