ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 31481: AMS : Yarn service - RPC metrics returns duplicate array elements
Date Fri, 27 Feb 2015 20:47:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31481/#review74578
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Feb. 27, 2015, 7:16 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31481/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 7:16 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Dmytro Sen, Erik Bergenholtz, Myroslav Papirkovskyy,
and Sid Wagle.
> 
> 
> Bugs: AMBARI-8994
>     https://issues.apache.org/jira/browse/AMBARI-8994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implemented proper downsampling algorithm. Fixed test data to reflect real production
scenarios.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
abd242e9676406f11e628ad0a64bf7808903e5fe 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricReportingAdapter.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDataTransferMethod.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDataTransferMethodFactory.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethodFactory.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
d8e0b65bd8108693f8832c3689bf08973a8d1456 
>   ambari-server/src/test/resources/ams/multiple_host_metrics.json 98d821a22a275dbe2f3823733494f25172f4bf95

>   ambari-server/src/test/resources/ams/single_host_metric.json 8e6c1e11947569cb7f5f1d57f9a9f48a530cd31e

> 
> Diff: https://reviews.apache.org/r/31481/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> deployment on a local VMs cluster -> no repro
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message