ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 31314: After cluster install one host doesn't have any stack version
Date Mon, 23 Feb 2015 20:37:00 GMT


> On Feb. 23, 2015, 3:08 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
line 1526
> > <https://reviews.apache.org/r/31314/diff/1/?file=873070#file873070line1526>
> >
> >     This may transition other host versions from INSTALL_FAILED to INSTALLED. I
believe we don't need the else block here.

Please contact me about this.  I'm open to suggestions - but I thought we couldn't have two
host_versions marked CURRENT at the same time.  So where can we get the value for the one
that's not current?  Remember - this is for hosts that have no reportable versions, so it
may be hard for anything other than INSTALLED or CURRENT.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31314/#review73651
-----------------------------------------------------------


On Feb. 23, 2015, 2:55 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31314/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 2:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9755
>     https://issues.apache.org/jira/browse/AMBARI-9755
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * When marking a cluster version as CURRENT, take into account hosts that don't advertise
version and add a host_version record.
> * Fixed error in a ZK import.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
c609b0a 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
92465a0 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
8865b26 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml e17bbd3

> 
> Diff: https://reviews.apache.org/r/31314/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on new and upgrading cluster.  Automated testing pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message