ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 30960: AMS : Kafka Metrics - Log flush status metrics do not show up.
Date Mon, 16 Feb 2015 15:35:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30960/#review72618
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metrics.json
<https://reviews.apache.org/r/30960/#comment118669>

    I think,
    
    "metrics/kafka/log/LogFlushStats/LogFlushRateAndTimeMs/max" should look like "metrics/kafka/log/LogFlushStats/LogFlushRateAndTimeMs/rate/max"
    and
    "kafka.log.LogFlushStats.LogFlushRateAndTimeMs.max" should look like
    "kafka.log.LogFlushStats.LogFlushRateAndTimeMs.max"_rate._max"
    
    Aggregation functions has been intoroduced in AMBARI-9604 Fix Flume Agent graphs on Ambari
service page
    
    But I can be wrong if kafka sends min/max/avg metrics itself


- Dmytro Sen


On Фев. 13, 2015, 11:13 п.п., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30960/
> -----------------------------------------------------------
> 
> (Updated Фев. 13, 2015, 11:13 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Erik Bergenholtz, Srimanth Gunturi, and Yusaku
Sako.
> 
> 
> Bugs: AMBARI-9612
>     https://issues.apache.org/jira/browse/AMBARI-9612
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed log flush status collection & display
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metrics.json 826c0e8a35fd90a425ed2bd029e4385040e8f41f

>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KAFKA/metrics.json
826c0e8a35fd90a425ed2bd029e4385040e8f41f 
>   ambari-web/app/messages.js f794271fd0e4a6205a14654a46e61197d69a9bda 
>   ambari-web/app/utils/ajax/ajax.js bfbc2dd570be2b67385bda31f2789b1345ae7b1a 
>   ambari-web/app/views/main/service/info/metrics/kafka/kafka_log_flush.js 240a89b854a147ea31ae1b83248d7c5cd08a8d7d

> 
> Diff: https://reviews.apache.org/r/30960/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> deployment on a local VMs cluster -> generated Kafka messages -> log flush status
graph gets populated ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message