ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 31046: Kerberos: Escape special characters in Distinguished Names used for queries in Active Directory
Date Sat, 14 Feb 2015 17:57:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31046/#review72504
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On Feb. 14, 2015, 12:43 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31046/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 12:43 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9637
>     https://issues.apache.org/jira/browse/AMBARI-9637
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Escape special characters in Distinguished Names used for queries in Active Directory,
else query (or attribute updates) will fail with an error like
> 
> ```
> [LDAP: error code 1 - 000020D6: SvcErr: DSID-0310081B, problem 5012 (DIR_ERROR), data
0 ^@]
> ```
> 
> The following characters should be escaped using a \:
> 
> * Forward Slash '/'
> * Comma	`,`
> * Backslash character 
> * Pound sign (hash sign) `#`
> * Plus sign `+`
> * Less than symbol	`<`
> * Greater than symbol `>`
> * Semicolon `;`
> * Double quote (quotation mark) `"`
> * Equal sign `=`
> * Leading or trailing spaces
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
2dbd50e 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
c51475e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
e5d7505 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
8dab409 
> 
> Diff: https://reviews.apache.org/r/31046/diff/
> 
> 
> Testing
> -------
> 
> Manually tested using a Keberized cluster and Active Directory
> 
> # Jenkins test results
> Running org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest
> Tests run: 19, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 1.175 sec
> 
> Running org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
> Tests run: 19, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.839 sec
> 
> Ambari server test suite
> Tests run: 2691, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:24 min
> [INFO] Finished at: 2015-02-14T05:51:25+00:00
> [INFO] Final Memory: 44M/519M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message