ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 31035: Allow the KDC admin credentials stored in session to be validated via the REST API
Date Sat, 14 Feb 2015 03:41:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31035/#review72481
-----------------------------------------------------------

Ship it!


Looks good.

- Tom Beerbower


On Feb. 14, 2015, 1 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31035/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 1 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Tom Beerbower, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9640
>     https://issues.apache.org/jira/browse/AMBARI-9640
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add the following properties to the Kerberos service resource which provide the results
of the validation of the KDC admin credentials stored in session: "Services/attributes/kdc_validation_result"
and "Services/attributes/kdc_validation_failure_details".
> 
> See the associated Jira for more details including full api responses.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
2e68c7d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
40921f5 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
210c6a4 
> 
> Diff: https://reviews.apache.org/r/31035/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional Testing:
> - Tested all possible results of the validation
> - Tested when no kerberos service existed
> 
> Unit Tests:
> - Added new unit tests
> - Running entire unit test suite now and will post results prior to merging
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message