ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi" <srima...@hortonworks.com>
Subject Re: Review Request 31006: Views : Clean up pom.xml files under ambari-views.
Date Fri, 13 Feb 2015 18:41:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31006/#review72412
-----------------------------------------------------------


Tom, I see other places in ambari code where '1.3.0-SNAPSHOT' is present (like /ambari/ambari-agent/conf/windows/ambari-agent.ps1,
/ambari/ambari-common/src/main/python/ambari_commons/ambari_service.py, etc.). Just wondering
if '1.3.0-SNAPSHOT' rename to '2.0.0' is needed for this JIRA?

- Srimanth Gunturi


On Feb. 13, 2015, 4:55 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31006/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 4:55 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-9631
>     https://issues.apache.org/jira/browse/AMBARI-9631
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Remove unnecessary dependencies in ambari-views pom.xml. 
> 
>       <dependency>
>         <groupId>com.google.inject</groupId>
>         <artifactId>guice</artifactId>
>         <version>4.0-beta</version>
>       </dependency>
>       <dependency>
>         <groupId>com.googlecode.json-simple</groupId>
>         <artifactId>json-simple</artifactId>
>         <version>1.1.1</version>
>       </dependency>
>       <dependency>
>         <groupId>org.apache.ambari</groupId>
>         <artifactId>ambari-views</artifactId>
>         <version>2.0.0.0</version>
>       </dependency>
> 
> 2. Update ambari.version property in all pom.xml files under ambari-views.
> 
> 
> Diffs
> -----
> 
>   ambari-views/examples/calculator-view/pom.xml ce89ebc 
>   ambari-views/examples/favorite-view/pom.xml 2d64dd9 
>   ambari-views/examples/hello-servlet-view/pom.xml f2c2438 
>   ambari-views/examples/helloworld-view/pom.xml d53e9d7 
>   ambari-views/examples/phone-list-view/pom.xml 6662011 
>   ambari-views/examples/property-validator-view/pom.xml 9429a86 
>   ambari-views/examples/property-view/pom.xml 45aebfa 
>   ambari-views/examples/restricted-view/pom.xml 3574f73 
>   ambari-views/examples/simple-view/pom.xml e23faca 
>   ambari-views/examples/weather-view/pom.xml fd6d5b6 
>   contrib/views/pom.xml e6037f3 
> 
> Diff: https://reviews.apache.org/r/31006/diff/
> 
> 
> Testing
> -------
> 
> No new functionality, so no new tests required.
> 
> All existing tests pass.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message