ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 30992: Keytab generation should use kerberos-env/encryption_types when creating key entries
Date Fri, 13 Feb 2015 16:47:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30992/#review72382
-----------------------------------------------------------

Ship it!


Looks fine to me.  It might be a good idea to have somebody from the UI team review the site_properties.js
change.

- Robert Nettleton


On Feb. 13, 2015, 1:56 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30992/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 1:56 p.m.)
> 
> 
> Review request for Ambari, Emil Anca, John Speidel, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9171
>     https://issues.apache.org/jira/browse/AMBARI-9171
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When generating keytab files the set of keys to be generated should be determined by
the set of encryption types listed in `kerberos-env/encryption_types`
> 
> The set of keys to be generated is determined by parsing the list of encryption types
specified in `kerberos-env/encryption_types`.  Certain types are not supported by the infractruture
and certain ones make the KDC angry. These are noted in the implemetaion either as documentation
when replacements are used or by setting the type to `EncryptionType.UNKNOWN`.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
4c1fdb5 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
a23aa81 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
b81fa59 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
f2c5d6f 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
99f2601 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
d23da8e 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
db1015a 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/krb5-conf.xml
9d229f7 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/templates/krb5_conf.j2
db1015a 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
4e0d8b0 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
2f205b2 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
41d98b4 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
314f2b2 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 6b3439a 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/KERBEROS.json b34c7b4 
>   ambari-web/app/data/HDP2/site_properties.js 60bcbe0 
> 
> Diff: https://reviews.apache.org/r/30992/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in clusters
> 
> #Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message