ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 30934: Kerberos: provide option to not generate kerb client krb5.conf
Date Thu, 12 Feb 2015 20:15:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30934/#review72237
-----------------------------------------------------------

Ship it!


looks good

- John Speidel


On Feb. 12, 2015, 4:16 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30934/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 4:16 p.m.)
> 
> 
> Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9578
>     https://issues.apache.org/jira/browse/AMBARI-9578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some environments, the kerb client krb5.conf is already managed on the machines and
ambari cannot generate or modify it.
> 
> Need to provide option to not have ambari create/overwrite krb5.conf.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
ba6beba 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
74b6f71 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
3a2c81f 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
2c3505c 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
83dd016 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/kdc_conf.j2
c067bae 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 46aff38 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/kadm5-acl.xml
293bcbf 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/kdc-conf.xml
ac41317 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/krb5-conf.xml
44bb209 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/scripts/kerberos_client.py
a341e8d 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/scripts/params.py
cff6250 
>   ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/templates/kdc_conf.j2
c067bae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
fd36d9d 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py b87b7ca 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 8b896c1 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
0e6ed83 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json d6c839d 
>   ambari-web/app/data/HDP2/site_properties.js d73d131 
> 
> Diff: https://reviews.apache.org/r/30934/diff/
> 
> 
> Testing
> -------
> 
> Manual testing in cluster.  Verified that /etc/krb5.conf is not altered if `krb5-conf/manage_krb5_conf`
is `false` and is altered/created if `krb5-conf/manage_krb5_conf` is `true`
> 
> #Jenkins test results
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.581 sec
> 
> Ambari-server java test suite
> Tests run: 2668, Failures: 0, Errors: 0, Skipped: 15
> 
> Running tests for stack:2.2 service:KERBEROS
> test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc_and_krb5conf (test_kerberos_client.TestKerberosClient) ...
ok
> test_get_property (test_kerberos_client.TestKerberosClient) ... ok
> test_set_keytab (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
> *test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok*
> *test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok*
> *test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok*
> 
> /----------------------------------------------------------------------
> Ran 11 tests in 0.163s
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:07 h
> [INFO] Finished at: 2015-02-12T14:23:15+00:00
> [INFO] Final Memory: 43M/538M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message