ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 30943: RU: downgrade during Prepare Backups step causes issues
Date Thu, 12 Feb 2015 19:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30943/#review72216
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/stack/HostsType.java
<https://reviews.apache.org/r/30943/#comment118238>

    Is this supposed to be ordered? We're using a HashSet down below and not enforcing the
concrete type in this declaration. I'd think we'd need a LinkedHashSet here.



ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
<https://reviews.apache.org/r/30943/#comment118239>

    Just a nit; I prefer 
    
    ```
    case OTHER:
    default:
      ...
    ````
    
    Since it calls out OTHER and makes it the default behavior.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
<https://reviews.apache.org/r/30943/#comment118244>

    Encapsulation?



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/30943/#comment118245>

    Double spaces after periods?


- Jonathan Hurley


On Feb. 12, 2015, 2:13 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30943/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 2:13 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9603
>     https://issues.apache.org/jira/browse/AMBARI-9603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Fixed case where manual tasks were being shown when the service does not get downgraded
> * Added directional element for groups and cluster execute-stage elements
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
f9336ef 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/HostsType.java 556e5fa 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
0800c91 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java f7a5276

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java cade1b0

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
bf7a068 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
7c001d9 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
ec517d9 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
81ec2ff 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 2e00b3e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
7df7b7b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
4c8cfc4 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 74b2495

>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
f4aa92d 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 3dd7f2f

> 
> Diff: https://reviews.apache.org/r/30943/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2658, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:12.157s
> [INFO] Finished at: Thu Feb 12 13:55:24 EST 2015
> [INFO] Final Memory: 31M/373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message