ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in https setup for hdfs and yarn, etc
Date Thu, 12 Feb 2015 16:17:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72182
-----------------------------------------------------------


I would like to see a new unit test(s) added that excercises this issue before you merge.
Also, please include the output that shows that the unit tests were successful.
You didn't mention whether you did manual functional testing of this patch.
My +1 assumes that you did, if not please do so.

Looks generally good to me but I don't know this code very well so please wait for Tom Beerbower's
review.


ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
<https://reviews.apache.org/r/30879/#comment118186>

    curious why you are not using a primitive boolean here



ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
<https://reviews.apache.org/r/30879/#comment118187>

    curious why you are not using a primitive boolean here


- John Speidel


On Feb. 11, 2015, 2:59 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 2:59 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-9566
>     https://issues.apache.org/jira/browse/AMBARI-9566
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM:
> 
> HDP 2.2.0, Ambari 1.7.0.  
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
> 
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
> 
> A few notes:  
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
> 
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
> 
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
4c47a1c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
65f7be7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
bbacb0d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
6572935 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
69fb5f5 
>   ambari-web/app/models/service_config.js 999d1b5 
> 
> Diff: https://reviews.apache.org/r/30879/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message