ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 30893: Fix NullPointerException during Blueprint Cluster startup
Date Thu, 12 Feb 2015 15:56:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30893/#review72176
-----------------------------------------------------------

Ship it!


Looks good although I have no knowledge of the js code.
Prior to pushing you should include the unit test output.

- John Speidel


On Feb. 11, 2015, 9:19 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30893/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 9:19 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, John Speidel, Robert Levas, and Yusaku Sako.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch resolves AMBARI-9584.
> 
> A NullPointerException was thrown during Blueprint configuration
>   processing, prior to a cluster startup attempt.
> 
> This exception was caused by a new configuration file, introduced
>   in AMBARI-9468.  The ams-hbase-security-site.xml configuration
>   file includes property names, but no values.  This causes
>   an exception in the Blueprint and Cluster configuration
>   processing.
> 
> This patch addresses the issue by:
> 
>  - Adding empty "<value>" tags to this new configuration file, in
>    order to avoid the NullPointerException.  This also brings this
>    new configuration file more into line with the other files
>    in the stack definitions, since no other file skips <value>
>    tags, even if the values are empty.
> 
>  - Updates site_properties.js in ambari-web to account for these
>    new properties as well, to ensure that the UI can handle these
>    properties as expected.  This portion of the patch was contributed
>    by Dmitry Sen.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
35d395f 
>   ambari-web/app/data/HDP2/site_properties.js 2b2294c 
> 
> Diff: https://reviews.apache.org/r/30893/diff/
> 
> 
> Testing
> -------
> 
> 1. Manually verified that single-node and multi-node clusters can be properly started
using a Blueprint, and including the Ambari Metrics Service. 
> 2. Ran the ambari-server unit tests, and only noticed the expected python failures.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message