ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rishi Pidva" <rpi...@pivotal.io>
Subject Re: Review Request 30862: AMBARI-9098 Cannot install new secure services to existing secure HDFS cluster
Date Wed, 11 Feb 2015 01:48:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30862/#review71902
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_service.py
<https://reviews.apache.org/r/30862/#comment117825>

    This is not completely necessary as I've added the logic to UI but I believe it's better
to do it in agent than in client (UI).



ambari-web/app/mixins/wizard/addSecurityConfigs.js
<https://reviews.apache.org/r/30862/#comment117826>

    This doesn't return the services which were just selected in UI. It only returns services
already installed which works for "Add Security" but doesn't work for "Add Service"



ambari-web/app/mixins/wizard/addSecurityConfigs.js
<https://reviews.apache.org/r/30862/#comment117827>

    Again, add service has no field or binding for kerberos domain so if you install and test
with default realm "EXAMPLE.COM", it works.. Anytime you have your own realm like "AMBARI.APACHE.ORG",
the call to getConfigValue() returns null as value.


- Rishi Pidva


On Feb. 10, 2015, 5:43 p.m., Rishi Pidva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30862/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 5:43 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, jun aoki, Nate Cole, and Vitthal Gogate.
> 
> 
> Bugs: AMBARI-9098
>     https://issues.apache.org/jira/browse/AMBARI-9098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add service fails to update the configuration properly due to missing properties in controller.
Also noticed there was issue in loading kerberos domain on Add service screen.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_service.py
ac4280a 
>   ambari-web/app/controllers/main/admin/security/add/step2.js 8ccd301 
>   ambari-web/app/data/HDP2/secure_mapping.js f4a17d9 
>   ambari-web/app/data/HDP2/secure_properties.js 7760dd2 
>   ambari-web/app/data/secure_mapping.js cfca947 
>   ambari-web/app/mixins/wizard/addSecurityConfigs.js 659f9cc 
> 
> Diff: https://reviews.apache.org/r/30862/diff/
> 
> 
> Testing
> -------
> 
> Manual testing for the following use cases:
> - Adding security to a basic cluster deployed via blueprint with HDFS, YARN, Mapred,
Zookeeper and Knox.
> - Adding Oozie service to secure cluster
> - Adding Hive service to secure cluster.
> - Removing security
> - Adding security back.
> 
> 
> Thanks,
> 
> Rishi Pidva
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message