ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 30849: Preserve kerberos auth_to_local rules when scaling kerberized cluster
Date Wed, 11 Feb 2015 01:33:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30849/#review71890
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
<https://reviews.apache.org/r/30849/#comment117807>

    It seems like this method should be named `addRules` or `addExistingRules` since it's
behavior is significantly different than the `addRule` method.



ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
<https://reviews.apache.org/r/30849/#comment117822>

    You left `String` capitalized here but changed other instances to `string`.... just an
observation...



ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
<https://reviews.apache.org/r/30849/#comment117823>

    



ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
<https://reviews.apache.org/r/30849/#comment117818>

    Would `org.apache.ambari.server.serveraction.kerberos.DeconstructedPrincipal` work rather
than this inner class?


- Robert Levas


On Feb. 10, 2015, 5:42 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30849/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 5:42 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-9022
>     https://issues.apache.org/jira/browse/AMBARI-9022
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When scaling a kerberized cluster need to ensure that existing auth_to_local rules are
preserved.
> Also, need to properly order all rules in the property from most to least specific.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
6017bed 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
ce319e6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java
fbb8ba1 
> 
> Diff: https://reviews.apache.org/r/30849/diff/
> 
> 
> Testing
> -------
> 
> Functional tests:
> added Oozie to existing cluster
> 
> Unit Tests:
> -New unit tests
> -All tests pass
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message