ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 30799: RU: upgrade task names should use display names rather than IDs
Date Mon, 09 Feb 2015 18:07:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30799/#review71651
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
<https://reviews.apache.org/r/30799/#comment117512>

    Why store these? Can't you just query the metainfo XML provider directly when needed?


- Jonathan Hurley


On Feb. 9, 2015, 11:45 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30799/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 11:45 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9533
>     https://issues.apache.org/jira/browse/AMBARI-9533
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Use AmbariMetaInfo in UpgradeHelper to get the display names for services/components
and store them with the UpgradeContext for use in the StageWrapperBuilder classes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
908e2d0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java bc53b37

>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 129baa6

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
6213de1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
fc51eb1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Direction.java
376de14 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
ba4dca1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
ac8b5dd 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
3bf9098 
> 
> Diff: https://reviews.apache.org/r/30799/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2655, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:05.563s
> [INFO] Finished at: Mon Feb 09 10:51:40 EST 2015
> [INFO] Final Memory: 34M/363M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message