ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 30737: RU: need to be able to abort an upgrade, including HOLDING states
Date Fri, 06 Feb 2015 18:33:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30737/#review71466
-----------------------------------------------------------

Ship it!


We do currently allow a PUT to an upgrade item (stage) in HOLDING status to ABORTED status.
 I think that it probably requires your change to ActionScheduler to actually work correctly
but it also calls actionManager.cancelRequest().

- Tom Beerbower


On Feb. 6, 2015, 5:52 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30737/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 5:52 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9515
>     https://issues.apache.org/jira/browse/AMBARI-9515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This addresses 2 issues:
> * We need to issue an ABORTED status to an upgrade.  We could do it on the request, but
that's odd, so I just added it to UpgradeResourceProvider.
> * The act of creating an abort was not working on HOLDING* statuses, which put the RU
in a place where other stages would run, but anything in HOLDING would block other progress.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
853eba5 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java
ddba2ff 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
5d0e6ed 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
ab3eff0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
6422069 
> 
> Diff: https://reviews.apache.org/r/30737/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2653, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:55.752s
> [INFO] Finished at: Fri Feb 06 12:50:23 EST 2015
> [INFO] Final Memory: 34M/369M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message