ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 30679: RU: hosts master check is not checking all masters
Date Fri, 06 Feb 2015 13:35:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30679/#review71425
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
<https://reviews.apache.org/r/30679/#comment117184>

    You can't do _all_ masters here, because some of them don't matter for RU. (Like AMS,
or MySql, Postgres for Oozie etc).  You should be cross-checking with the upgrade pack to
see what services are defined there AND are masters AND are installed, as services in the
upgrade pack may or may not be installed.



ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
<https://reviews.apache.org/r/30679/#comment117182>

    Could also do serviceComponent.getServiceComponentHosts().keySet() for the host names


- Nate Cole


On Feb. 5, 2015, 1:13 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30679/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 1:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9498
>     https://issues.apache.org/jira/browse/AMBARI-9498
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The hosts master check is not properly checking all hosts.  The check is currently checking
only things like NN master etc.  This needs to check any master that is part of the upgrade-2.2.xml
upgrade script, including any service-defined master (like Hive masters, ZK, etc).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
647f2d1 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
91ca65a 
> 
> Diff: https://reviews.apache.org/r/30679/diff/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message