ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 30670: Call to save configs of different services together should 400 return code not 500
Date Thu, 05 Feb 2015 16:49:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30670/
-----------------------------------------------------------

Review request for Ambari and John Speidel.


Bugs: AMBARI-9495
    https://issues.apache.org/jira/browse/AMBARI-9495


Repository: ambari


Description
-------

This AmbariException will need to be caught upstream and translated to an
IllegalArgumentException (or thrown from here) which will result in the
expected 400 Bad Request response back to the user. If the AmbariException is
not caught, it will result in a 500 Server Error to the user which is not
appropriate.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 514c8e0 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4a8c020

  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java bb6a713

  ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
f65bbd9 

Diff: https://reviews.apache.org/r/30670/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message