ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 30641: RU: overall upgrade process is 100% before upgrade is done
Date Thu, 05 Feb 2015 14:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30641/#review71208
-----------------------------------------------------------

Ship it!


Looks good.

- Tom Beerbower


On Feb. 4, 2015, 10:34 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30641/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 10:34 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9481
>     https://issues.apache.org/jira/browse/AMBARI-9481
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Fixed HostRoleCommand to return a better hashCode(), equals() as the old implementations
did not consider that two tasks would have the same member values
> * Added computation for groups
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
59fce90 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
24a4589 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
28e0d17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java
c89d005 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
ca1e583 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
00ba387 
> 
> Diff: https://reviews.apache.org/r/30641/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2642, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:54.495s
> [INFO] Finished at: Wed Feb 04 17:21:08 EST 2015
> [INFO] Final Memory: 32M/368M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message