ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 30559: Call to save configs of different services together not rejected
Date Wed, 04 Feb 2015 19:10:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30559/#review71012
-----------------------------------------------------------


WTF?!
You merged this without addressing the objection that I raised?

- John Speidel


On Feb. 3, 2015, 4:41 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30559/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 4:41 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-9449
>     https://issues.apache.org/jira/browse/AMBARI-9449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Request info:  
> Request URL:<http://162.216.150.79:8080/api/v1/clusters/c1>  
> Request Method:PUT  
> Status Code:200 OK
> 
> Data:
> 
>     
>     
>     
>     {"Clusters":{"desired_config":[
>     {"type":"hive-site","tag":"version1421327958802","properties":{}},
>     {"type":"yarn-site","tag":"version1421327958802","properties":{}}
>     ]}}
>     
> 
> PUT call to server doesn't actually save configs and create config version,
> but return status OK.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 6b8a917 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
db17109 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
c4dfdb8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
8ebf2ce 
> 
> Diff: https://reviews.apache.org/r/30559/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message