ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 30577: Adding new host after version distribution does not contain 2 host versions
Date Tue, 03 Feb 2015 21:27:36 GMT


> On Feb. 3, 2015, 9:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java,
line 145
> > <https://reviews.apache.org/r/30577/diff/1/?file=846540#file846540line145>
> >
> >     Technically, this should only be if the state is in [INSTALLING, INSTALL_FAILED,
INSTALLED], because the other states [UPGRADING, UPGRADE_FAILED, UPGRADED] are handled once
the host heartbeats

On second thought, your method is more strict, since adding a host while the upgrade is in
progress should also be out_of_sync. The implications are complicated because while the actual
rolling upgrade is in progress, the user can only continue or downgrade, but cannot re-distribute
bits.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/#review70831
-----------------------------------------------------------


On Feb. 3, 2015, 9:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30577/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 9:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9464
>     https://issues.apache.org/jira/browse/AMBARI-9464
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish
installing the version. Then add a new host selecting all the components you can select. The
new host's Versions page has only 1 row having the old version.
> It should have 2 rows - one for the old version and one for the new version. Old versions
button should be disabled while the new versions button should be enabled. Clicking on the
new version button should install the new components there.
> Also, the admin-versions page should have action to install as opposed to perform-upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
c2748df 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
4d8f3be 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30577/diff/
> 
> 
> Testing
> -------
> 
> unit test run
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message