ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 30571: Issue with namenode format
Date Tue, 03 Feb 2015 18:55:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30571/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.


Bugs: AMBARI-9461
    https://issues.apache.org/jira/browse/AMBARI-9461


Repository: ambari


Description
-------

Appears to be a bug:
checkForFormat.sh looks for a "$
{mark_dir}" to determine if the namenode dir is formatted.
But "${mark_dir}
" seems to be hardcoded to /var/lib/hdfs/namenode/formatted
when it should instead use
{dfs.namenode.data.dir}
/formatted/.
That results in:
…/formatted/ never being created (it tries but the parent dir /var/lib/hdfs/namenode doesn’t
exist so it can’t)
…/formatted/ not being checked on cluster build
I’ve temporarily hacked around the issue by applying a symbolic link before Ambari automation
starts:
mkdir /hadoop/hdfs; ln -s /hadoop/hdfs /var/lib/
(where /hadoop/hdfs is the base of all hdfs dirs. Result in /hadoop/hdfs/namenode/formatted
being available at /var/lib/hdfs/namenode/formatted)


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkForFormat.sh
54405f6 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
143abd8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
472d684 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 441e697 

Diff: https://reviews.apache.org/r/30571/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [6.814s]
[INFO] Ambari Server ..................................... SUCCESS [31.299s]
[INFO] Ambari Agent ...................................... SUCCESS [17.130s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57.270s
[INFO] Finished at: Tue Feb 03 21:55:17 FET 2015
[INFO] Final Memory: 38M/273M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message