ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 30568: [PREVIEW] Rolling Upgrade Bootstrap - Allow Ambari upgrade from 1.7.0 - 2.0.0 to populate new tables
Date Tue, 03 Feb 2015 18:32:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review70784
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
<https://reviews.apache.org/r/30568/#comment116210>

    This typically happens while all services are stopped and no agents are heartbeating.
Wouldn't the task fail?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
<https://reviews.apache.org/r/30568/#comment116214>

    Should log the exception.



ambari-server/src/main/resources/custom_actions/scripts/request_component_info.py
<https://reviews.apache.org/r/30568/#comment116212>

    Prefer to use named imports. Seems like call, Fail, Logger, get_component_version are
not needed.


- Alejandro Fernandez


On Feb. 3, 2015, 6:19 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 6:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9054
>     https://issues.apache.org/jira/browse/AMBARI-9054
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Current implementation schedules request to every component to get its version after
server upgrade 1.7.0 - 2.0.0 was completed. It creates a stage per every component and thus
looks ugly. I'm in the process of rewriting it to use AmbariCustomCommandExecutionHelper to
call save_component_version_to_structured_out() directly for every component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
b8f3cd7 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
a83d26d 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
777ced7 
>   ambari-server/src/main/resources/custom_actions/scripts/request_component_info.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/30568/diff/
> 
> 
> Testing
> -------
> 
> preview
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message