Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============1580015367756885741=="
MIME-Version: 1.0
Subject: Re: Review Request 30380: Implement unkerberize for kerberized
 cluster
From: "Robert Levas" <rlevas@hortonworks.com>
To: "John Speidel" <jspeidel@hortonworks.com>,
 "Robert Nettleton" <rnettleton@hortonworks.com>
Cc: "Robert Levas" <rlevas@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Fri, 30 Jan 2015 20:29:20 -0000
Message-ID: <20150130202920.18486.23724@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Robert Levas" <noreply@reviews.apache.org>
References: <20150130171833.4427.39260@reviews.apache.org>
In-Reply-To: <20150130171833.4427.39260@reviews.apache.org>
Reply-To: "Robert Levas" <rlevas@hortonworks.com>

--===============1580015367756885741==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 30, 2015, 12:18 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java, line 630
> > <https://reviews.apache.org/r/30380/diff/1/?file=839153#file839153line630>
> >
> >     seems odd that the absense of a filter is the same as the filter containing the service.  Just confirming that this is correct.

This is correct... if no filter is specified, than all services are included; if an empty filter is specified, then no services will be incuded.


> On Jan. 30, 2015, 12:18 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java, line 1589
> > <https://reviews.apache.org/r/30380/diff/1/?file=839153#file839153line1589>
> >
> >     This "may" be an issue.  After I refactored Stacks, (BAD) changes were made regarding how config properties are returned from the service. Now when you ask for a services properties, you will also get any "excluded" properties.  So, you will need to get the services excluded config types and remove all properties for those types from the properties that are returned.  This is a complete mess and once again a HACK was introduced instead of fixing the root issue which was how a few callers were using the getProperties() method.

I will fix as suggested. Thanks for finding this.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30380/#review70375
-----------------------------------------------------------


On Jan. 28, 2015, 4:49 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30380/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 4:49 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9360
>     https://issues.apache.org/jira/browse/AMBARI-9360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement the ability to disable Kerberos from a cluster that was previously configured for Kerberos.
> 
> This entails reverting configuration properties set when Kerberos was enabled to default values found in the stack. 
> 
> Principals will not be destroyed in the KDC and ketyab files will not be removed from hosts.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 6bb9bf1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java e976d81 
> 
> Diff: https://reviews.apache.org/r/30380/diff/
> 
> 
> Testing
> -------
> 
> Manual testing in clusters against MIT KDC and Active Directory
> Updated Unit test
> 
> # Jenkins test results
> 
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.534 sec
> 
> Ambari server test suite
> Tests run: 2626, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:06 h
> [INFO] Finished at: 2015-01-28T21:42:39+00:00
> [INFO] Final Memory: 44M/528M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


--===============1580015367756885741==--