Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEC9F17BDD for ; Fri, 30 Jan 2015 09:53:06 +0000 (UTC) Received: (qmail 82244 invoked by uid 500); 30 Jan 2015 09:53:04 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 82208 invoked by uid 500); 30 Jan 2015 09:53:04 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 82161 invoked by uid 99); 30 Jan 2015 09:52:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 09:52:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2CE511C680E; Fri, 30 Jan 2015 09:52:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7266458056114878759==" MIME-Version: 1.0 Subject: Re: Review Request 30429: Allow cluster and service artifacts to be updated and deleted From: "Tom Beerbower" To: "Robert Levas" , "Robert Nettleton" , "Tom Beerbower" Cc: "John Speidel" , "Ambari" Date: Fri, 30 Jan 2015 09:52:53 -0000 Message-ID: <20150130095253.25679.60188@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30429/ X-Sender: "Tom Beerbower" References: <20150129223224.25679.18558@reviews.apache.org> In-Reply-To: <20150129223224.25679.18558@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============7266458056114878759== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30429/#review70341 ----------------------------------------------------------- Ship it! Looks good. - Tom Beerbower On Jan. 29, 2015, 10:32 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30429/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 10:32 p.m.) > > > Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-9410 > https://issues.apache.org/jira/browse/AMBARI-9410 > > > Repository: ambari > > > Description > ------- > > Allow artifact resource for cluster and service to be updated and deleted via the api. > Adds update and delete functionality to the endpoints: > /clusters/api/v1/clusters/:clusterName/artifacts > /clusters/api/v1/clusters/:clusterName/services/:serviceName/artifacts > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 5f44b2f > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 8a2642b > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java e476f62 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ArtifactDAO.java 4b7cf25 > ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java c8f020e > ambari-server/src/test/java/org/apache/ambari/server/api/services/ServiceServiceTest.java 5ca3fb3 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java 046c5d8 > > Diff: https://reviews.apache.org/r/30429/diff/ > > > Testing > ------- > > Manual functional testing including updating and deleting cluster and service artifacts. > Unit Tests: > - added new tests > - all tests pass > > Tests run: 2630, Failures: 0, Errors: 0, Skipped: 15 > ... > Total run:586 > Total errors:0 > Total failures:0 > > > Thanks, > > John Speidel > > --===============7266458056114878759==--