Return-Path: 
 <dev-return-56638-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A6E70104B9
	for <apmail-ambari-dev-archive@www.apache.org>;
 Fri, 23 Jan 2015 18:50:58 +0000 (UTC)
Received: (qmail 96836 invoked by uid 500); 23 Jan 2015 18:50:58 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 96796 invoked by uid 500); 23 Jan 2015 18:50:58 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 96782 invoked by uid 99); 23 Jan 2015 18:50:58 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 18:50:58 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 76ABE1D3371;
	Fri, 23 Jan 2015 18:50:54 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2640927958479785132=="
MIME-Version: 1.0
Subject: Review Request 30222: Views: NPE on getProperties
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Fri, 23 Jan 2015 18:50:54 -0000
Message-ID: <20150123185054.9402.95015@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/30222/
X-Sender: "Tom Beerbower" <noreply@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============2640927958479785132==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30222/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-9307
    https://issues.apache.org/jira/browse/AMBARI-9307


Repository: ambari


Description
-------

There is an issue in the view context implementation that it passes nulls along to Velocity for template parameterization. It results in the following ...

    java.lang.NullPointerException
	    at java.io.StringReader.<init>(StringReader.java:50)
    	at org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1265)
	    at org.apache.velocity.app.Velocity.evaluate(Velocity.java:180)
	    at org.apache.ambari.server.view.ViewContextImpl.parameterize(ViewContextImpl.java:409)
	    at org.apache.ambari.server.view.ViewContextImpl.getProperties(ViewContextImpl.java:194)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 438ee75 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java 94d5458 

Diff: https://reviews.apache.org/r/30222/diff/


Testing
-------

Manual testing with Slider view.
Updated existing unit tests for null property case.

All existing tests pass ...

Results :

Tests run: 2595, Failures: 0, Errors: 0, Skipped: 15


Thanks,

Tom Beerbower


--===============2640927958479785132==--