Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0821D10147 for ; Fri, 23 Jan 2015 17:50:14 +0000 (UTC) Received: (qmail 96496 invoked by uid 500); 23 Jan 2015 17:50:14 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 96459 invoked by uid 500); 23 Jan 2015 17:50:14 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 96445 invoked by uid 99); 23 Jan 2015 17:50:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 17:50:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E1A6C1D3371; Fri, 23 Jan 2015 17:50:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4728328029224874258==" MIME-Version: 1.0 Subject: Re: Review Request 30219: AMS: certain metric charts look incorrect From: "Myroslav Papirkovskyy" To: "Myroslav Papirkovskyy" , "Sid Wagle" Cc: "Dmytro Sen" , "Ambari" Date: Fri, 23 Jan 2015 17:50:09 -0000 Message-ID: <20150123175009.9402.46406@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Myroslav Papirkovskyy" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30219/ X-Sender: "Myroslav Papirkovskyy" References: <20150123174702.9401.79364@reviews.apache.org> In-Reply-To: <20150123174702.9401.79364@reviews.apache.org> Reply-To: "Myroslav Papirkovskyy" X-ReviewRequest-Repository: ambari --===============4728328029224874258== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30219/#review69418 ----------------------------------------------------------- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 23, 2015, 7:47 після полудня, Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30219/ > ----------------------------------------------------------- > > (Updated Січ. 23, 2015, 7:47 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-9305 > https://issues.apache.org/jira/browse/AMBARI-9305 > > > Repository: ambari > > > Description > ------- > > Garbage collection time (on HDFS and YARN, not sure if there are others) look incorrect. > HDFS I/O metrics chart (bytes written and read) look incorrect > > > Diffs > ----- > > ambari-metrics/ambari-metrics-common/pom.xml 7bfd9f1 > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 5e89e14 > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java PRE-CREATION > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a8d3a37 > > Diff: https://reviews.apache.org/r/30219/diff/ > > > Testing > ------- > > tests passed > > > Thanks, > > Dmytro Sen > > --===============4728328029224874258==--