Return-Path: 
 <dev-return-56485-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4298C17A33
	for <apmail-ambari-dev-archive@www.apache.org>;
 Fri, 23 Jan 2015 02:13:26 +0000 (UTC)
Received: (qmail 53141 invoked by uid 500); 23 Jan 2015 02:13:25 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 53098 invoked by uid 500); 23 Jan 2015 02:13:25 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 52471 invoked by uid 99); 23 Jan 2015 02:13:25 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 02:13:25 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 87AD61D5CAA;
	Fri, 23 Jan 2015 02:13:21 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5152643564692289379=="
MIME-Version: 1.0
Subject: Re: Review Request 30202: RU - Fix hardcoded Namenode address and JMX
 port
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Yurii Shylov" <yurii.shylov@gmail.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>
Date: Fri, 23 Jan 2015 02:13:21 -0000
Message-ID: <20150123021321.9402.62641@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/30202/
X-Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150123021153.9402.92641@reviews.apache.org>
In-Reply-To: <20150123021153.9402.92641@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5152643564692289379==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30202/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 2:13 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Yurii Shylov.


Changes
-------

Fixed unit test.


Bugs: AMBARI-9289
    https://issues.apache.org/jira/browse/AMBARI-9289


Repository: ambari


Description
-------

Java-side:
UpgradeHelper hardcodes the JMX port number when figuring out the active and standby namenodes.

Python-side:
When using HA mode, the JMX URLs for NameNode must be taken from dfs.namenode.http-address.<cluster>.<nn#>
See journalnode_upgrade.py
E.g.,
dfs.namenode.http-address.ha.nn1 : c6405.ambari.apache.org:50070
dfs.namenode.http-address.ha.nn2 : c6403.ambari.apache.org:50070


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java f49e66675fbf1289cd7b797784f14bd8d631f1bf 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java ba5e804acea3a888036822aa2ec9789f536418d6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 746a04ace69a4d8b1c66215901d351f8a2395ef9 
  ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 239c79c7c1d5b4896a8ab1b90611caef0baced20 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 122e0a3b5e3de9084bd8282104c1642237ae5184 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java e3d8619df3a6f0f579b8e592f0ac6bdf51be610f 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java 38ac6435e0876c946101582856b5a4a6e19ef5dd 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HostAndPort.java PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py 4e85130d3538f0d76a093a7e0cbcdefec4f6088b 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 2634ce8fe1255d1d8a3b8a11ae1b6d17b2dc779e 
  ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java e6cc089a1c3a465e87eabc2f1bd7832d62f9b0a7 
  ambari-server/src/test/java/org/apache/ambari/server/utils/TestHTTPUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/30202/diff/


Testing
-------

Verified that both fixes worked in a 3-node HA cluster when performing a Rolling Upgrade.
The first item is to allow the resolution of the active/standby namendoes to occur, which is needed by Namenode Prepare and RESTART.
The second item is for the Journalnode restart to query JMX correctly.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:14.455s
[INFO] Finished at: Thu Jan 22 18:11:41 PST 2015
[INFO] Final Memory: 50M/758M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


--===============5152643564692289379==--