Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7F1F10234 for ; Thu, 22 Jan 2015 07:52:29 +0000 (UTC) Received: (qmail 76620 invoked by uid 500); 22 Jan 2015 07:52:29 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 76584 invoked by uid 500); 22 Jan 2015 07:52:29 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 76569 invoked by uid 99); 22 Jan 2015 07:52:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jan 2015 07:52:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 81D981CA922; Thu, 22 Jan 2015 07:52:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8780026636152779360==" MIME-Version: 1.0 Subject: Re: Review Request 30156: Versions: cannot register version From: "Andriy Babiichuk" To: "Yusaku Sako" , "Andriy Babiichuk" , "Srimanth Gunturi" Cc: "Richard Zang" , "Ambari" Date: Thu, 22 Jan 2015 07:52:25 -0000 Message-ID: <20150122075225.9401.72109@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andriy Babiichuk" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30156/ X-Sender: "Andriy Babiichuk" References: <20150122064103.9401.98749@reviews.apache.org> In-Reply-To: <20150122064103.9401.98749@reviews.apache.org> Reply-To: "Andriy Babiichuk" X-ReviewRequest-Repository: ambari --===============8780026636152779360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30156/#review69141 ----------------------------------------------------------- Ship it! Ship It! - Andriy Babiichuk On Янв. 22, 2015, 6:41 д.п., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30156/ > ----------------------------------------------------------- > > (Updated Янв. 22, 2015, 6:41 д.п.) > > > Review request for Ambari, Andriy Babiichuk, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-9252 > https://issues.apache.org/jira/browse/AMBARI-9252 > > > Repository: ambari > > > Description > ------- > > ng-if create its own scope, need to refer to $parent when use ng-model in ng-if > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 18a5700 > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 11d42f9 > > Diff: https://reviews.apache.org/r/30156/diff/ > > > Testing > ------- > > Manually tested in live cluster. All unit test passed. > > > Thanks, > > Richard Zang > > --===============8780026636152779360==--