Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3403988415574244674=="
MIME-Version: 1.0
Subject: Re: Review Request 30136: Fix post-install hook for hdp-select
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>, "Yurii Shylov" <yurii.shylov@gmail.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Wed, 21 Jan 2015 21:35:06 -0000
Message-ID: <20150121213506.9401.76841@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20150121213051.9402.27634@reviews.apache.org>
In-Reply-To: <20150121213051.9402.27634@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============3403988415574244674==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 21, 2015, 9:30 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, lines 27-30
> > <https://reviews.apache.org/r/30136/diff/3/?file=828837#file828837line27>
> >
> >     Any tests that exercise this code that need to be taken care of?

patch does not break existing tests


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69016
-----------------------------------------------------------


On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============3403988415574244674==--