Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D43E610ED5 for ; Tue, 20 Jan 2015 16:44:33 +0000 (UTC) Received: (qmail 10168 invoked by uid 500); 20 Jan 2015 16:44:33 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 10136 invoked by uid 500); 20 Jan 2015 16:44:33 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 10120 invoked by uid 99); 20 Jan 2015 16:44:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 16:44:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CDE6F1C9A45; Tue, 20 Jan 2015 16:44:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2953133146541391441==" MIME-Version: 1.0 Subject: Re: Review Request 30077: Upgrades: Make a ResourceDefinition for UpgradeResourceProvider for downgrade directive From: "Jonathan Hurley" To: "Nate Cole" , "Jonathan Hurley" Cc: "Tom Beerbower" , "Ambari" Date: Tue, 20 Jan 2015 16:44:29 -0000 Message-ID: <20150120164429.9402.55949@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/30077/ X-Sender: "Jonathan Hurley" References: <20150120154136.9402.58907@reviews.apache.org> In-Reply-To: <20150120154136.9402.58907@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============2953133146541391441== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30077/#review68732 ----------------------------------------------------------- Ship it! Ship It! - Jonathan Hurley On Jan. 20, 2015, 10:41 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30077/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 10:41 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-9214 > https://issues.apache.org/jira/browse/AMBARI-9214 > > > Repository: ambari > > > Description > ------- > > Add an Upgrade ResourceDefinition so that we can use these directives: > > downgrade: boolean that makes the upgrade a downgrade > skip_service_checks: boolean that disables the upcoming service-check-all after core components > > > Also cleaned up a sloppy cut and paste job in ClientConfigResourceDefinition. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java 1cd7e17 > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClientConfigResourceDefinition.java 4ff37ac > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java fc28c13 > ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java 92ecd1e > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d9c9aec > ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 73aa828 > ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java d264511 > ambari-server/src/test/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinitionTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java cd5f23e > > Diff: https://reviews.apache.org/r/30077/diff/ > > > Testing > ------- > > Unit tests added. All existing tests pass. > > Manual tests in progress... > > > Thanks, > > Tom Beerbower > > --===============2953133146541391441==--