Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3686180840329904937=="
MIME-Version: 1.0
Subject: Re: Review Request 29969: Rollling Upgrade - Server bootstrap creates
 incorrect repo version
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Yurii Shylov" <yurii.shylov@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 19 Jan 2015 19:13:16 -0000
Message-ID: <20150119191316.9402.47056@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150117010142.23995.76532@reviews.apache.org>
In-Reply-To: <20150117010142.23995.76532@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============3686180840329904937==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29969/#review68658
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 17, 2015, 1:01 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29969/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 1:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9183
>     https://issues.apache.org/jira/browse/AMBARI-9183
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently on clean install Ambari creates cluster entity and its repository version with version taken from selected stack. I.e. for stack HDP-2.2, version 2.2 is written to database, without any information about the actual minor version of that stack. Besides that we can't assume that cluster has some version until it has at least one of components of that version.
> Repository version creation should be detached from cluster creation; instead of that versions should be created after receiving the first actual version from service responses during install.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b5fda49 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6dabcbb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java befd014 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java ed9fa24 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java fd0188c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 19a5f9f 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 9ec8c36 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 31606ca 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 57c0223 
> 
> Diff: https://reviews.apache.org/r/29969/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55:35.812s
> 
> 
> Tested clean install and rolling upgrade manually on 2-node cluster
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


--===============3686180840329904937==--