Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5513717304 for ; Thu, 15 Jan 2015 04:54:52 +0000 (UTC) Received: (qmail 64853 invoked by uid 500); 15 Jan 2015 04:54:54 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 64813 invoked by uid 500); 15 Jan 2015 04:54:54 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 64798 invoked by uid 99); 15 Jan 2015 04:54:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jan 2015 04:54:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8CA5A1D392F; Thu, 15 Jan 2015 04:54:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3993966513546908873==" MIME-Version: 1.0 Subject: Re: Review Request 29897: Upgrades: Downgrade for Failure Scenarios during upgrade process From: "Jonathan Hurley" To: "Alejandro Fernandez" , "Tom Beerbower" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Thu, 15 Jan 2015 04:54:50 -0000 Message-ID: <20150115045450.23995.94394@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29897/ X-Sender: "Jonathan Hurley" References: <20150114235814.23997.14038@reviews.apache.org> In-Reply-To: <20150114235814.23997.14038@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============3993966513546908873== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29897/#review68202 ----------------------------------------------------------- Ship it! ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java Document how specifying a version changes the behavior of the MHR? ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java Documentation ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java I don't think you need the null check here; `!m_version.equals(sch.getVersion())` should be enough since `m_version` cannot be null. ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java Documentation - Jonathan Hurley On Jan. 14, 2015, 6:58 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29897/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 6:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower. > > > Bugs: AMBARI-9135 > https://issues.apache.org/jira/browse/AMBARI-9135 > > > Repository: ambari > > > Description > ------- > > Added version checking for downgrades only. Upgrades should always use all services and components > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 0a11aca > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 2c19da3 > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 724bcdc > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java 8ea259d > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 04e8eb3 > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java ef605ec > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java dae920e > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4e61f36 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 59031f7 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7b64212 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql bfb49e5 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e6f2edb > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 2888eca > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 113de2d > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 73531ec > > Diff: https://reviews.apache.org/r/29897/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 26:06.457s > [INFO] Finished at: Wed Jan 14 18:56:49 EST 2015 > [INFO] Final Memory: 31M/345M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============3993966513546908873==--