Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BFCA1079A for ; Tue, 13 Jan 2015 23:28:20 +0000 (UTC) Received: (qmail 89191 invoked by uid 500); 13 Jan 2015 23:28:22 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 89152 invoked by uid 500); 13 Jan 2015 23:28:22 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 89136 invoked by uid 99); 13 Jan 2015 23:28:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 23:28:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A86AE1D2CB8; Tue, 13 Jan 2015 23:28:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6420677837795944414==" MIME-Version: 1.0 Subject: Re: Review Request 29868: Kerberos wizard: Back button does not work on Configure Kerberos page From: "Yusaku Sako" To: "Xi Wang" , "Srimanth Gunturi" , "Yusaku Sako" Cc: "Ambari" , "Jaimin Jetly" Date: Tue, 13 Jan 2015 23:28:18 -0000 Message-ID: <20150113232818.23995.71935@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29868/ X-Sender: "Yusaku Sako" References: <20150113232402.23995.32429@reviews.apache.org> In-Reply-To: <20150113232402.23995.32429@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============6420677837795944414== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29868/#review67972 ----------------------------------------------------------- Ship it! Ship It! - Yusaku Sako On Jan. 13, 2015, 11:24 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29868/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:24 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-9114 > https://issues.apache.org/jira/browse/AMBARI-9114 > > > Repository: ambari > > > Description > ------- > > Along with fixing the primary issue of navigation for back button on Configure Kerberos page, this patch also makes changes in the popover description for the "Test Connectivity" button on this page. > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/kerberos/step2_controller.js ae0cdff > ambari-web/app/messages.js b1e0ea8 > ambari-web/app/routes/add_kerberos_routes.js 624db82 > ambari-web/app/views/wizard/controls_view.js 7ac3511 > > Diff: https://reviews.apache.org/r/29868/diff/ > > > Testing > ------- > > tested e2e on a live cluster. > > **ambari-web unit test result with the patch:** > > 5237 tests complete (7 seconds) > 60 tests pending > > > Thanks, > > Jaimin Jetly > > --===============6420677837795944414==--