Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4974900303321138706=="
MIME-Version: 1.0
Subject: Review Request 29858: Manual Upgrade Tasks Should Be More Explicit
 And
 Parameterized
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Tue, 13 Jan 2015 18:55:28 -0000
Message-ID: <20150113185528.23995.88041@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============4974900303321138706==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29858/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-9109
    https://issues.apache.org/jira/browse/AMBARI-9109


Repository: ambari


Description
-------

For Hive upgrade, the following manual step was shown:
{noformat}
Run the SQL file at /usr/hdp/$version/hive/scripts/metastore/upgrade to update the Hive Metastore schema.
{noformat}

This is too vague.  I could not figure out what to do.
1. It should tell the user exactly which host this needs to be done on.
2. $version should be substituted with the actual directory name.
3. There are 40+ SQL files in the aforementioned "upgrade" folder.  What's the exact command that I need to run?

All services that use Manual Tasks as part of the upgrade should be revisited once the parameterization code is completed to ensure that the messages are correct. These include: Hive, Falcon, Oozie, HDFS


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java 4df0f9c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 46d0dd4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java b8d8502 
  ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java b453362 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 5882e3e 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java ac30762 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml c110a0b 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 53505f2 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml b777d94 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml aee1fcf 

Diff: https://reviews.apache.org/r/29858/diff/


Testing
-------

New tests written, full tests pending...


Thanks,

Jonathan Hurley


--===============4974900303321138706==--