Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DCAE10D2C for ; Tue, 13 Jan 2015 02:07:06 +0000 (UTC) Received: (qmail 2763 invoked by uid 500); 13 Jan 2015 02:07:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 2730 invoked by uid 500); 13 Jan 2015 02:07:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 2703 invoked by uid 99); 13 Jan 2015 02:07:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 02:07:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 50AD41D294E; Tue, 13 Jan 2015 02:07:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4181714400298034332==" MIME-Version: 1.0 Subject: Re: Review Request 29701: Design admin principal session expiration handling API call From: "Robert Levas" To: "John Speidel" , "Nate Cole" , "Robert Nettleton" , "Jaimin Jetly" Cc: "Robert Levas" , "Ambari" Date: Tue, 13 Jan 2015 02:07:03 -0000 Message-ID: <20150113020703.23996.88608@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29701/ X-Sender: "Robert Levas" References: <20150108042939.26560.66432@reviews.apache.org> In-Reply-To: <20150108042939.26560.66432@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============4181714400298034332== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29701/ ----------------------------------------------------------- (Updated Jan. 12, 2015, 9:07 p.m.) Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Robert Nettleton. Changes ------- This is a rather large change to add new exceptions to indicate Kerberos related error conditions. Some cleanup was done on `ADKerberosOperationHandler` and the relevant KerberosOperationHandler unit tests. Bugs: AMBARI-9014 https://issues.apache.org/jira/browse/AMBARI-9014 Repository: ambari Description ------- Provide the standard error code that will be returned along with the error message. If administrative credentials are not available { "status" : 400, "message" : "java.lang.IllegalArgumentException: Missing KDC administrator credentials" } If administrative credentials are not valid, for example, incorrect principal or password (or keytab) { "status" : 400, "message" : "java.lang.IllegalArgumentException: Invalid KDC administrator credentials" } Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 9662669 ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 0533228 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java a8eed2b ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java be70ba1 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java a6392da ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosAdminAuthenticationException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosKDCConnectionException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosLDAPContainerException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java ae2d4b2 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java 30e3c35 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosRealmException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java a99628c ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 04d43a5 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/TrustingSSLSocketFactory.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8f39f21 ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java 9f0e7ed ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java 92a4100 ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 4c7e49d ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java 72d58e2 ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java b61b76f Diff: https://reviews.apache.org/r/29701/diff/ Testing ------- Manaully tested in test cluster #Jenkins Test Results Running org.apache.ambari.server.controller.KerberosHelperTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.632 sec Running org.apache.ambari.server.stack.KerberosDescriptorTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.19 sec [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:00 h [INFO] Finished at: 2015-01-08T04:22:16+00:00 [INFO] Final Memory: 44M/513M [INFO] ------------------------------------------------------------------------ Thanks, Robert Levas --===============4181714400298034332==--